Declare function no longer works

[msnyder701]

I'm using Excel for Office 365 and up until a couple of weeks ago (or thereabouts) this statement gave no trouble:

Private Declare Function apiShowWindow Lib "user32" Alias "ShowWindow" _
            (ByVal hWnd As Long, ByVal nCmdShow As Long) As Long

Now, trying to save a program with this line in it gives me a sharing violation and an access violation. Can someone please help? Thanks!!

[arnelgp]

if you are using x64, you need to change the declaration, with conditional compiler directives:

#If VBA7 Then
Private Declare PtrSafe Function apiShowWindow Lib "user32" Alias "ShowWindow" _
(ByVal hWnd As LongPtr, ByVal nCmdShow As Long) As Long
#Else
Private Declare Function apiShowWindow Lib "user32" Alias "ShowWindow" _
(ByVal hWnd As Long, ByVal nCmdShow As Long) As Long
#End If

[msnyder701]

That's what I had thought, but it still doesn't work. I get the following error message: "The document was saved successfully, but Excel cannot re-open it because of a sharing violation. Please close the document and try to open it again."

[msnyder701]

if you are using x64, you need to change the declaration, with conditional compiler directives:

#If VBA7 Then
Private Declare PtrSafe Function apiShowWindow Lib "user32" Alias "ShowWindow" _
(ByVal hWnd As LongPtr, ByVal nCmdShow As Long) As Long
#Else
Private Declare Function apiShowWindow Lib "user32" Alias "ShowWindow" _
(ByVal hWnd As Long, ByVal nCmdShow As Long) As Long
#End If

[arnelgp]

there is similar problem here:
Excel 2016 Sharing violation - Microsoft Community

[Paul_Hossler]

According to the MS 32/64 document

Declare PtrSafe Function ShowWindow Lib "user32" Alias "ShowWindow" (ByVal hwnd As LongPtr, ByVal nCmdShow As Long) As Long

[arnelgp]

According to the MS 32/64 document

Declare PtrSafe Function ShowWindow Lib "user32" Alias "ShowWindow" (ByVal hwnd As LongPtr, ByVal nCmdShow As Long) As Long

that is if you are using Office 2010 and newer.

[Aussiebear]

I believe the OP stated they were using Excel for Office 365

[Bob Phillips]

All handles should be LongPtr in a 64bit environment.

[arnelgp]

In post 1, only OP is using 365.

[Paul_Hossler]

All handles should be LongPtr in a 64bit environment.

Agreed, but I think it also works with 32 bit office

https://docs.microsoft.com/en-us/off...6)%26rd%3Dtrue

LongPtr (Long integer on 32-bit systems, LongLong integer on 64-bit systems) variables are stored as:

• Signed 32-bit (4-byte) numbers ranging in value from -2,147,483,648 to 2,147,483,647 on 32-bit systems
• Signed 64-bit (8-byte) numbers ranging in value from -9,223,372,036,854,775,808 to 9,223,372,036,854,775,807 on 64-bit systems

LongPtr is not a true data type because it transforms to a Long in 32-bit environments, or a LongLong in 64-bit environments. Using LongPtr enables writing portable code that can run in both 32-bit and 64-bit environments. Use LongPtr for pointers and handles.

[Bob Phillips]

<p>

Agreed, but I think it also works with 32 bit office https://docs.microsoft.com/en-us/off...6)%26rd%3Dtrue

That would suggest that we should just declare every long as LongPtr, 32bit or 64bit, and the conditional code is only necessary for PtrSafe? Might explain why it works when I have declared a non-handle variable as LongPtr.</p>

[PhilS]

That would suggest that we should just declare every long as LongPtr, 23bit or 64bit, and the conditional code is only necessary for PtrSafe? Might explain why it works when I have declared a non-handle variable as LongPtr.

The conditional compilation for VBA7 is necessary for LongPtr and PtrSafe because these keywords only exist in VBA7.

As for "just declare every long as LongPtr", you will get away with declaring most Long variables as LongPtr but not all of them.
If you are interested in the details, I recommend my text Windows API declarations in VBA for 64-bit. (It mentions Microsoft Access in some locations, but the same is also true Excel, Word, and any other VBA enabled application.)

[Paul_Hossler]

The conditional compilation for VBA7 is necessary for LongPtr and PtrSafe because these keywords only exist in VBA7. As for "just declare every long as LongPtr", you will get away with declaring most Long variables as LongPtr but not all of them. If you are interested in the details, ...

Don't know


I don't have enough versions (2010, 2013, 2016, 365) and 32/64 bit to test